Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No trap for no veiws entered #335

Closed
JoelleEmmily opened this issue Mar 5, 2022 · 2 comments
Closed

No trap for no veiws entered #335

JoelleEmmily opened this issue Mar 5, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@JoelleEmmily
Copy link

Script allows null to be entered into number of views requested, then terminates ungraciously
@MShawon
Copy link
Owner

MShawon commented Mar 5, 2022

You're right.. what's your suggestions? Should it accept a default value for views when null entered? ask user again or something better?

@JoelleEmmily
Copy link
Author

JoelleEmmily commented Mar 5, 2022 •
edited

If it were up to me, I'd have the script throw an error and prompt again

Or delete itself with the error message, "your too dump to use this program"... although, I did cause the error myself...

@MShawon MShawon added the enhancement New feature or request label Apr 26, 2022
MShawon added a commit that referenced this issue May 1, 2022
@MShawon
resolves issue #298 , #299 , #319 , #322 , #335 , #336 , #337 , #358,…
421dc04 
… discount code, graceful ctrl+c
@MShawon MShawon closed this as completed May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoelleEmmily @MShawon