Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Load Config Timeout #409

Closed
2 of 4 tasks
yah00078 opened this issue Jul 23, 2022 · 2 comments
Closed
2 of 4 tasks

Add Load Config Timeout #409

yah00078 opened this issue Jul 23, 2022 · 2 comments

Comments

@yah00078
Copy link

yah00078 commented Jul 23, 2022

Is there an existing issue for this?

  • I have searched the existing issues

I'm submitting a ...

Description

Hello, when program starts it ask for use already known configuration until you press enter or input "no" (Line 949 & 951)

I think it could be a good idea to add a timeout for automate script launch (If you don't input nothing, after 30s it launch with found config) or a force yes param.

After some searches found some way to do this, but using an arg or a jsons config for self accepting seems to be easier than code a timeout function for input()

Thank you for all your job ! :-)

Environment

- OS : Linux
- Python : 3.8
- Script version : latest

config.json

Not really needed
@MShawon
Copy link
Owner

MShawon commented Jul 24, 2022

Adding echo yes | before actual command should work regardless of OS.

Linux
echo yes | python3 youtube_viewer.py

Windows
echo yes | python youtube_viewer.py

Windows EXE
echo yes | youtube_viewer.exe

I might look into timeout in future release however I think echo yes is an excellent option

@yah00078
Copy link
Author

Hello,
ihmo integrate feature in soft seems to be much cleaner, but you're answer work perfectly :-)
When i have time, I'd suggest a pull request to do.

thank you !

MShawon added a commit that referenced this issue Sep 25, 2022
@MShawon MShawon closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants