Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust toolchain version for CI to 1.64 #13

Closed
wants to merge 1 commit into from

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Sep 23, 2022

This aims to unblock #12 .

Since core::ptr::addr_of is not stablized until Rust 1.51, the current toolchain version used in appveyor is too old to build. According to the MSVC policy for this project i.e. Always the latest stable, we can update the specified version to let CI pass.

@poliorcetics
Copy link

Raising the MSRV to 1.51 should be enough, even if it's possible to raise to 1.64 there is no need to. It would be less disruptive across the ecosystem too

@bdbai
Copy link
Contributor Author

bdbai commented Sep 23, 2022

@poliorcetics unfortunately the current nightly toolchain (that some CI checks are using) already rejects the code 😭 That means I have to do the upgrade and fix in one go. I have rebased #12 and this might have to be closed.

I believe the version specified here is used for CI checks only and probably will not affect downstream users.

@bdbai bdbai closed this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants