Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides in file name with spaces is not working #145

Closed
mkusz opened this issue Oct 13, 2022 · 5 comments
Closed

Slides in file name with spaces is not working #145

mkusz opened this issue Oct 13, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@mkusz
Copy link

mkusz commented Oct 13, 2022

Describe the bug
When file name contains spaces, advanced slides preview do not work.

Samples to Reproduce

  1. Create new note with spaces in file name
  2. Create simple slide
  3. Open slide preview
  4. Preview will be blank

Expected behavior
Slides preview works when spaces are in file name

@mkusz mkusz added the bug Something isn't working label Oct 13, 2022
@MSzturc
Copy link
Owner

MSzturc commented Oct 14, 2022

nice find, will fix this issue with next version

@MSzturc
Copy link
Owner

MSzturc commented Oct 14, 2022

Can you provide me a sample where this problem occurs?
I've tried to reproduce it (on MacOS) and was not able to:

image

@mkusz
Copy link
Author

mkusz commented Oct 17, 2022

image

I also see some error in dev tools:

image

No sure but maybe it's some sort of problem with other plugin interaction.

@mkusz
Copy link
Author

mkusz commented Oct 18, 2022

@MSzturc was playing a bit with file names, and it seems that the space is not a problem. The problem is with ? at the end of the file name. ? is changed to %3F by obsidian (take a look at previous message console screenshot) but on MacOS (not sure about other systems) real file name contains ? not %3F. It seems that the problem is with file name conversion not with spaces. Probably other chars could have the same problem. Hope it helps with fix creation.
PS. Should I rename issue title?

@mkusz mkusz changed the title Slides in file name with spaces id not working Slides in file name with spaces is not working Oct 20, 2022
@MSzturc
Copy link
Owner

MSzturc commented Nov 3, 2022

will be fixed with 1.19

@MSzturc MSzturc closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants