Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Store player rankings instead of calculating them at run-time #183

Closed
ClobberXD opened this issue Aug 2, 2018 · 4 comments
Closed

Comments

@ClobberXD
Copy link
Contributor

Advantages

  • Automation of rank-based incentives. e.g. Auto-granting of vote_starter to players who enter the top 20 and revoking it from those who are pushed out of it.
  • No calculation required every time /rankings is invoked. Just fetch the rank from the ctf_stats mod storage like the other stats.

Disadvantages

  • One-time migration, when the ranks of all players have to be calculated and stored.
  • Updating a player's rank for every kill. Maybe update only once at end of match?
@Thomas--S
Copy link
Member

I think that the vote_starter priv should be granted manually. Being in the top 20 doesn't neccessarily qualify someone to use this priv responsibly; while a trustable player at rank 25 (as an example) might make good use of this privilege for the benefit of all. So a manual verification is absolutely neccessary, imho.

@rubenwardy
Copy link
Member

This would bloat the file storage if done badly. Would be better to add some caching instead

@ClobberXD
Copy link
Contributor Author

@Thomas--S I agree, we definitely should grant vote_starter on the basis of a more robust criteria. That was just an example for rank-based/score-based automation though.

@rubenwardy That's true. Any idea how this can be achieved by adding some sort of caching?

@AKryukov92
Copy link
Contributor

How much disk space do you have, rubenwardy?
Log files are usually contain text, which is very lightweight. Zipping files can reduce disk space even further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants