Crashes server if using the --terminal option and chat

[grantcarthew]

Hi,
I have raised this issue with the afkkick mod however it is also an issue here.

Rather than duplication the details, I'll reference the issue in the afkkick mod.

GunshipPenguin/afkkick#4

[ClobberXD]

This issue indeed seems to be caused by playerName being nil. A simple if-playerName-then check ought to fix this crash. i.e.

minetest.register_on_chat_message(function(playerName, message)
+	-- Verify that there is a player, and the player is online
+	if not playerName or not minetest.get_player_by_name(playerName) then
+		return
+	end
	players[playerName]["lastAction"] = minetest.get_gametime()
end)

OTOH, it seems pretty inconsistent of Minetest to pass a nil value here - I'd expect the value of the setting name (this is the name the terminal chat functions under) to be passed in.

[grantcarthew]

Does this mod get synced with the source mod at @GunshipPenguin?

[ClobberXD]

AFAIK, no. There doesn't seem to be any new commits, apart from GunshipPenguin/afkkick#3 which was backported from CTF. CTF's version, however, is a little more active, and has gone through the following changes:

• Before modpack re-organisation
• After modpack re-organisation

---

Given that we don't sync with upstream, I think it's a good idea to fix this crash in CTF itself.

[grantcarthew]

Ok.
Seems a shame to have duplicates.
I found this today: https://github.com/minetest-mods/
Instructions here: http://minetest-mods.github.io/

Maybe it is worth getting it supported under there? Then import the module into CTF? Just a suggestion.

[ClobberXD]

Thanks for reporting this crash. Fixed in 3de7c43.