Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few additions to the README.md #1144

Merged
merged 39 commits into from
Aug 21, 2023
Merged

Conversation

src4026
Copy link
Contributor

@src4026 src4026 commented May 1, 2023

Some extra information and clarifying edits.

Copy link
Contributor

@farooqkz farooqkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
@farooqkz
Copy link
Contributor

farooqkz commented May 5, 2023

My review is not complete, yet. I'm busy elsewhere.

@src4026
Copy link
Contributor Author

src4026 commented May 5, 2023

I clicked resolve. Was it the correct option? Thanks for the formatting and other stuff. @farooqkz , what's LCTM?

@farooqkz
Copy link
Contributor

farooqkz commented May 5, 2023

No you clicked the wrong button :)

You should commit my suggestions if you agree with them.

@src4026
Copy link
Contributor Author

src4026 commented May 5, 2023

No you clicked the wrong button :)

You should commit my suggestions if you agree with them.

Oh lel. I am on phone so I might need to navigate a bit more.

src4026 and others added 4 commits May 5, 2023 17:30
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
@src4026
Copy link
Contributor Author

src4026 commented May 5, 2023

I switched to my browser and committed some changes. Did it work? ^π^

@farooqkz
Copy link
Contributor

farooqkz commented May 5, 2023

I switched to my browser and committed some changes. Did it work? ^π^

Yes but more review is required. Also I appreciate your work and effort. Hopefully, you'll learn Lua and contribute code as well :)

@src4026
Copy link
Contributor Author

src4026 commented May 5, 2023

Yes but more review is required. Also I appreciate your work and effort. Hopefully, you'll learn Lua and contribute code as well :)

Yes, more work has to be done. Thanks :D.

@src4026
Copy link
Contributor Author

src4026 commented May 5, 2023

Btw I did learn Lua. I just have to start with Minetest modding basics whenever I get sufficient time.

mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
mods/ctf/ctf_map/README.md Outdated Show resolved Hide resolved
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
src4026 and others added 9 commits May 6, 2023 10:46
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
Removing line.

Co-authored-by: a-blob <88883098+a-blob@users.noreply.github.com>
src4026 and others added 2 commits May 14, 2023 21:22
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
@src4026
Copy link
Contributor Author

src4026 commented Jun 10, 2023

@a-blob I have added this line instead of the method that wasted the placement of the corners etc.:

### 6. Export 

1. Press "Finish Editing"
2. Find the exported map located in `[Mintest folder]/worlds/[Map World]/schems/[Exported Map folder]`
3. Move the exported map folder to `\[Minetest folder]/games/capturetheflag/mods/ctf/ctf_map/maps`.

You can access the exported map by running `/ctf_map editor`, clicking on the exported map folder from the list of maps, and then by pressing "Start Editing". 

I suppose it is obvious that the maker has to repeat the process for every edit they make onwards?

src4026 and others added 2 commits June 25, 2023 23:48
@src4026 src4026 requested a review from LoneWolfHT August 3, 2023 13:10
@src4026
Copy link
Contributor Author

src4026 commented Aug 3, 2023

I have made some changes, so I request a review. Also, is there anything stopping the merge of this PR or is it that it is still incomplete?

@LoneWolfHT LoneWolfHT merged commit 5fc58d3 into MT-CTF:master Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants