Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings GUI #1238

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Improve settings GUI #1238

merged 6 commits into from
Nov 20, 2023

Conversation

a-blob
Copy link
Contributor

@a-blob a-blob commented Oct 16, 2023

Improve the settings GUI so texts are no longer cut-off like this:
image

I also made the settings take the full inventory since I don't think anyone needs to view their inventory while using settings. Doing this also prevents users from getting through the trouble of scrolling through the settings inventory and accidentally modifying options with the scrollwheel.
image

@a-blob a-blob marked this pull request as ready for review October 16, 2023 11:32
@src4026
Copy link
Contributor

src4026 commented Oct 16, 2023

In case, if one happens to put a long enough text as a setting, would it still cut off?

@a-blob
Copy link
Contributor Author

a-blob commented Oct 16, 2023

In case, if one happens to put a long enough text as a setting, would it still cut off?

Yes. There are solutions though, like adding a new line or adding a horizontal scrollbar.

@src4026
Copy link
Contributor

src4026 commented Oct 16, 2023

Yes. There are solutions though, like adding a new line or adding a horizontal scrollbar.

New lines would be temporary and not applicable to all, the scrollbar sounds better. Wrapping text could be another way if possible.

@a-blob
Copy link
Contributor Author

a-blob commented Oct 17, 2023

Wrapping text is not possible here AFAIK, unless you wrap it manually with \n.

@LoneWolfHT LoneWolfHT merged commit 4d8bfa6 into MT-CTF:master Nov 20, 2023
1 check passed
@a-blob a-blob deleted the update-settings-inv branch November 20, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants