Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight visited chests #985

Merged
merged 12 commits into from
Oct 11, 2022
Merged

Highlight visited chests #985

merged 12 commits into from
Oct 11, 2022

Conversation

xenonca
Copy link
Contributor

@xenonca xenonca commented Feb 4, 2022

Make it visible for your teammates when a chest has already been opened by someone.
AFAIK it is not (yet) possible to change node textures during run time, this is why I'm using minetest.swap_node().

@LoneWolfHT
Copy link
Member

How are opened chests handled in MTG?

@savilli
Copy link
Contributor

savilli commented Feb 4, 2022

mods/ctf/ctf_map/nodes.lua Outdated Show resolved Hide resolved
mods/ctf/ctf_map/nodes.lua Outdated Show resolved Hide resolved
@xenonca
Copy link
Contributor Author

xenonca commented Feb 4, 2022

How are opened chests handled in MTG?

I think I should have been more clear with the explanation, what I mean is that visited chests, chests that have already been touched/opened by a player, will be distinguishable from untouched ones.

@xenonca xenonca changed the title Mark opened chests as opened Highlight visited chests Feb 4, 2022
@appgurueu
Copy link
Contributor

appgurueu commented Feb 6, 2022

Looks like massive code duplication to me; shouldn't this basically be the same def. as the treasure chest except for the tiles (and maybe glow)? Why don't you table.copy the treasure chest def. and alter it then?

After some more thought, I believe the ideal solution might be "treasure boxes" which when dug drop all their contents.

mods/ctf/ctf_map/nodes.lua Outdated Show resolved Hide resolved
@xenonca xenonca requested a review from savilli July 20, 2022 15:44
mods/ctf/ctf_map/nodes.lua Outdated Show resolved Hide resolved
Copy link
Contributor

@savilli savilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: MΛGN☰TΛR <legitmagnetar@gmail.com>
@LoneWolfHT LoneWolfHT merged commit 954e983 into MT-CTF:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants