-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classes rework #994
Classes rework #994
Conversation
@appgurueu you may review if interested. Performance improvements may be possible combat-wise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as short as it could be. Some things are hacky.
82f20ee
to
f88d622
Compare
24ddf88
to
f728700
Compare
I think I've addressed everything, just need to add a user setting for the wielditem displaying now |
157d97a
to
7e3cbf1
Compare
7e3cbf1
to
e4de553
Compare
Note: Those warnings |
I'm going to revert the knight sword change, and use it in a new mode later on. Code is ready for review |
-- ctf_melee.register_sword("ctf_mode_classes:knight_sword", { | ||
-- description = "Knight Sword", | ||
-- inventory_image = "default_tool_bronzesword.png", | ||
-- damage_groups = {fleshy = 5}, | ||
-- }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outcommented code. Has to be removed eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured I'd leave it there for a bit as a reminder
Going to merge now, I will keep an eye on the server to fix any issues that arise. This has had testing already so I think it will go smoothly |
No description provided.