Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plain_battle #30

Merged
merged 9 commits into from May 13, 2019
Merged

update plain_battle #30

merged 9 commits into from May 13, 2019

Conversation

JostP
Copy link
Member

@JostP JostP commented Apr 9, 2019

I made update for my plain battle map:
-more useful buildings (wall and fortress)
-6 meses in mine in each hunter's house
Zaslonska slika 2019-04-09 17-53-55
Zaslonska slika 2019-04-09 17-52-46
Zaslonska slika 2019-04-09 17-52-54
Zaslonska slika 2019-04-09 17-55-00
Zaslonska slika 2019-04-09 17-52-19
Zaslonska slika 2019-04-09 17-51-35

@Thomas--S
Copy link
Member

I reviewed this and the update seems to be very promising.

I suggest to remove the doors and furnances from the hunter's houses. They don't work (because of missing metadata). This will confuse players.

I think that it would be easier for players if the directions were marked with red/blue wool. I think of the following places:

  • The very center castle made of stonebrick
  • The desert stonebrick castles
  • Maybe the forest watchtowers

It might also be a good idea to place the old wooden castles from the previous version at the very empty, forest-less side of the map.

@JostP
Copy link
Member Author

JostP commented May 11, 2019

Wool mark, remove doors and furnaces

Zaslonska slika 2019-05-11 09-39-59

@Thomas--S
Copy link
Member

I think that using breakable wool with breakable structures might be a little bit better.

Furthermore, I'd prefer it, if the wool colors were visible in the inside room of the center stonebrick castle.

Are you going to re-add the wooden castles, too, as suggested above? It isn't mandatory, I'd only like to know whether you'll do this or not, so I know when this update is ready for merge.

@JostP
Copy link
Member Author

JostP commented May 11, 2019

I think that using breakable wool with breakable structures might be a little bit better.

I don't think this is a good idea, if players dig wool they can place it everywhere (on the enemy castle for example).

Furthermore, I'd prefer it, if the wool colors were visible in the inside room of the center stonebrick castle.

I will fix that

Are you going to re-add the wooden castles, too, as suggested above? It isn't mandatory, I'd only like to know whether you'll do this or not, so I know when this update is ready for merge.

No, there won't be battles in the forest and I don't think we need it.

@Thomas--S
Copy link
Member

I don't think this is a good idea, if players dig wool they can place it everywhere (on the enemy castle for example).

I don't agree with you here. Re-placing the wool can be used as a strategy, e.g. to irritate the enemy etc. It can also be used to mark additional structures.

Furthermore, I'd prefer it, if the wool colors were visible in the inside room of the center stonebrick castle.

I will fix that

Thanks :)

No, there won't be battles in the forest and I don't think we need it.

Ok. I only thought the old castles were to good to be deleted :)

But I can understand your point of view, and I'm totally fine with it.

@Thomas--S
Copy link
Member

👍 Very nice update! Thanks!

@Thomas--S Thomas--S added Enhancement New feature or request One approval ✅ labels May 11, 2019
@JostP
Copy link
Member Author

JostP commented May 11, 2019

Thank you for review :).

10_plain_battle.conf Outdated Show resolved Hide resolved
@JostP
Copy link
Member Author

JostP commented May 13, 2019

I saw yesterday that gun (small black one) destroys wool. Wool is on castles at the middle, where players will shoot a lot. Maybe it's better idea to make wool indestructible?

Should I add 10_plain_battle.png to .conf file?

And should I add screenshots to karsthafen maps?

@ClobberXD
Copy link
Contributor

ClobberXD commented May 13, 2019

Adding indestructible wool on top of a destructible castle would result in floating wool if and when the castle below is destroyed, and wouldn't look nice. If you want to make the wool indestructible, I suggest you make the castle indestructible too. Or you can just leave it as it is, either option is fine with me.

EDIT: Yes, please add screenshots (they should be exactly 600x400) to your Karsthafen PRs.

@Thomas--S
Copy link
Member

I definitely prefer the whole castles, including the wool, being destructible.
Destroying the wool with guns doesn't seem like a big problem to me.

I already prepared a screenshot for this update of Plain Battle, but feel free to include your own.

Copy link
Contributor

@ClobberXD ClobberXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like the new improvements. Great work 👍

@ClobberXD ClobberXD added Two approvals 🎉 Waiting for merge and removed One approval ✅ labels May 13, 2019
@JostP
Copy link
Member Author

JostP commented May 13, 2019

I definitely prefer the whole castles, including the wool, being destructible.
Destroying the wool with guns doesn't seem like a big problem to me.

I already prepared a screenshot for this update of Plain Battle, but feel free to include your own.

I like your screenshot, I just wanted to ask if I have to add line 10_plain_battle.png to .conf file. Thank you for your review too ClobberXD.

@ClobberXD
Copy link
Contributor

@JostP Yes, please do add screenshot = 10_plain_battle.png to the map meta.

@ClobberXD ClobberXD merged commit 55e6231 into MT-CTF:master May 13, 2019
@JostP JostP deleted the update_plain_battle branch May 13, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Review required 🔍 Two approvals 🎉 Waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants