change based on comments #2531

MTES-MCT · May 7, 2024 · 78451d6 · 78451d6
1 parent 84fa19d
commit 78451d6
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 2 deletions.
diff --git a/assets/styles/histologe.scss b/assets/styles/histologe.scss
@@ -773,6 +773,10 @@ h2, h3 {
     }
 }
 
+#tags_active_container, #tags_inactive_container{
+    .fr-badge{cursor: pointer;}
+}
+
 
 @media (min-width: 992px) {
     .text-align-right--lg {

diff --git a/src/Controller/Back/SignalementActionController.php b/src/Controller/Back/SignalementActionController.php
@@ -194,7 +194,6 @@ public function switchValue(Signalement $signalement, Request $request, EntityMa
     {
         $this->denyAccessUnlessGranted('SIGN_EDIT', $signalement);
         if ($this->isCsrfTokenValid('signalement_switch_value_'.$signalement->getUuid(), $request->get('_token'))) {
-            $return = 0;
             $value = $request->get('value');
 
             $tag = $entityManager->getRepository(Tag::class)->find((int) $value);
@@ -207,7 +206,7 @@ public function switchValue(Signalement $signalement, Request $request, EntityMa
             $entityManager->persist($signalement);
             $entityManager->flush();
 
-            return $this->json(['response' => 'success', 'return' => $return]);
+            return $this->json(['response' => 'success']);
         }
 
         return $this->json(['response' => 'error'], 400);

diff --git a/tests/Functional/Controller/Back/SignalementActionControllerTest.php b/tests/Functional/Controller/Back/SignalementActionControllerTest.php
@@ -59,4 +59,47 @@ public function testDeleteSuivi(): void
         $this->assertStringContainsString(Suivi::DESCRIPTION_DELETED, $suivi->getDescription());
         $this->assertResponseRedirects('/bo/signalements/'.$signalement->getUuid().'#suivis');
     }
+
+    public function testSwitchValue(): void
+    {
+        $signalement = $this->signalementRepository->findOneBy(['uuid' => '00000000-0000-0000-2023-000000000010']);
+
+        $route = $this->router->generate('back_signalement_switch_value', ['uuid' => $signalement->getUuid()]);
+        $this->client->request('GET', $route);
+
+        $this->client->request(
+            'POST',
+            $route,
+            [
+                'value' => 1,
+                '_token' => $this->generateCsrfToken($this->client, 'KO'),
+            ]
+        );
+        $this->assertResponseHeaderSame('Content-Type', 'application/json');
+        $this->assertEquals('{"response":"error"}', $this->client->getResponse()->getContent());
+
+        $this->client->request(
+            'POST',
+            $route,
+            [
+                'value' => 1,
+                '_token' => $this->generateCsrfToken($this->client, 'signalement_switch_value_'.$signalement->getUuid()),
+            ]
+        );
+        $this->assertResponseHeaderSame('Content-Type', 'application/json');
+        $this->assertEquals('{"response":"success"}', $this->client->getResponse()->getContent());
+
+        $this->client->request(
+            'POST',
+            $route,
+            [
+                'value' => 3,
+                '_token' => $this->generateCsrfToken($this->client, 'signalement_switch_value_'.$signalement->getUuid()),
+            ]
+        );
+        $this->assertResponseHeaderSame('Content-Type', 'application/json');
+        $this->assertEquals('{"response":"success"}', $this->client->getResponse()->getContent());
+        $this->assertEquals(1, $signalement->getTags()->count());
+        $this->assertEquals(3, $signalement->getTags()->first()->getId());
+    }
 }