Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intégration SISH] Ajouter contrôle sur adresse proprio #1314

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Jun 5, 2023

Ticket

#1292

Description

Esabora a besoin d'avoir des adresses de proprio valide. Jusqu'à maintenant aucune suggestion d’adresse n'est faite sur le champ adresse du propriétaire, il faut donc permettre au formulaire de suggérer des adresses lors l'auto-complétion de ce champs.

Changements apportés

  • Conditionnement de la méthode searchAddress afin de permettre le remplissage sur 1 seul champs au lieu de 3

Tests

  • Déposer un formulaire avec saisie adresse pro


// Zip codes available for Non Conformité Energétique
isZipForNDE = (zipOccupant == '63' || zipOccupant == '89');
if ("signalement_adresseOccupant" === t.id) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai pas dupliqué sur const.js et ces fichiers ne passeront pas l'été

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un petit commentaire, test OK

src/Form/SignalementType.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
7.7% 7.7% Duplication

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi

@emilschn emilschn merged commit c48318b into develop Jun 5, 2023
4 checks passed
@sfinx13 sfinx13 deleted the feature/1292-adresse-proprio branch June 21, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants