Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Passage en Symfony 6.4 #2105

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Conversation

numew
Copy link
Collaborator

@numew numew commented Jan 12, 2024

Ticket

#2096

Description

  • Upgrade vers Symfony 6.4
  • Upgrade league/flysystem-bundle
  • Suppression sensio/framework-extra-bundle
  • Suppression de dépréciations et corrections sur les routes

Il reste quelques dépréciations que je n'ai pas su supprimer)

Pré-requis

make composer

Tests

  • La CI s'en charge mais faire quelque vérifications manuelle

@numew numew changed the title Feature/2096 upgrade symfony 6.4 [QA] Passage en Symfony 6.4 Jan 12, 2024
config/packages/doctrine.yaml Show resolved Hide resolved
config/packages/framework.yaml Outdated Show resolved Hide resolved
@hmeneuvrier
Copy link
Collaborator

J'ai fait le parcours de base sur la plateforme sans rencontrer de souci

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai lancé le projet, y'a 2 dépréciations qu'on peut gérer du moins celle qui me parle

User Deprecated: Since symfony/dependency-injection 6.4: "Symfony\Component\DependencyInjection\ContainerAwareTrait" is deprecated, use dependency injection instead.

Injection de dépendances dans les migrations bien qu'elle ai deja été joué

User Deprecated: Version detection logic for MySQL will change in DBAL 4. Please specify the version as the server reports it, e.g. "5.7.40" instead of "5.7". (AbstractMySQLDriver.php:81 called by AbstractDriverMiddleware.php:68, doctrine/dbal#5779, package doctrine/orm)

La version dans la chaine de connexion ou dans le fichier de conf doctrine directement (préférer celle ci )

#server_version: '13'

@numew

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi

@emilschn
Copy link
Collaborator

emilschn commented Jan 15, 2024

Tests de parcours ok pour moi aussi !
(je laisse Saidi valider quand les retours seront faits, puis merger)

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

6.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@numew
Copy link
Collaborator Author

numew commented Jan 17, 2024

J'ai lancé le projet, y'a 2 dépréciations qu'on peut gérer du moins celle qui me parle

User Deprecated: Since symfony/dependency-injection 6.4: "Symfony\Component\DependencyInjection\ContainerAwareTrait" is deprecated, use dependency injection instead.

Injection de dépendances dans les migrations bien qu'elle ai deja été joué

-> Honnêtement je ne vois pas comment faire

User Deprecated: Version detection logic for MySQL will change in DBAL 4. Please specify the version as the server reports it, e.g. "5.7.40" instead of "5.7". (AbstractMySQLDriver.php:81 called by AbstractDriverMiddleware.php:68, doctrine/dbal#5779, package doctrine/orm)

La version dans la chaine de connexion ou dans le fichier de conf doctrine directement (préférer celle ci )

#server_version: '13'

-> Ok pour celle ci

@sfinx13 sfinx13 merged commit 8876cf1 into develop Jan 17, 2024
2 of 3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2096-upgrade-symfony-6.4 branch January 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants