Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Cartographie] Correction pour éviter l'absence d'affichage si le nom de l'occupant est vide #2108

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

emilschn
Copy link
Collaborator

Ticket

#2106

Description

Dans le nouveau formulaire, selon les profils, le nom de l'occupant est facultatif.
Sur la cartographie, lorsqu'on affiche les signalements, on met le nom de l'occupant en majuscule.
Si on appelle la méthode pour mettre en majuscule sur du vide, on a une erreur JS.

Tests

  • Raccourci : supprimer le nom de l'occupant dans un signalement via la BDD et vérifier que la carto s'affiche toujours
  • Proprement : dans le nouveau formulaire, faire un signalement en tiers service de secours et ne pas remplir le nom de l'occupant, puis vérifier qu'il s'affiche tout de même dans la carto

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test et relecture OK

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test et lecture OK

@numew numew merged commit 85433e5 into develop Jan 12, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the fix/2106-carto-with-empty-nomoccupant branch January 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants