[Signalement - BO] Import Données 67 Bas Rhin #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfinx13
reviewed
Jan 17, 2024
| foreach ($partnersName as $partnerName) { | ||
| $partnerNameCleaned = preg_replace('/[\x00-\x1F\x7F\xA0]/u', '', $partnerName); // remove non printable chars |
sfinx13
reviewed
Jan 17, 2024
| use Psr\Log\LoggerInterface; | ||
| use Symfony\Component\Console\Helper\ProgressBar; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
| use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface; | ||
|
|
||
| class SignalementImportLoader | ||
| { | ||
| private const FLUSH_COUNT = 200; | ||
| private const FLUSH_COUNT = 20; |
There was a problem hiding this comment.
Un peu plus de 20 c'était pas possible, j'imagine ?
There was a problem hiding this comment.
c’était possible mais j'ai préféré réduire vu que le temps de traitement avec les images augmente pas mal et que j'ai supprimé le flush dans la partie loadFiles
sfinx13
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
J'approuve la PR (test + code OK)
Warinig remonté sur le channel https://mattermost.incubateur.net/betagouv/pl/6nc8fnmiitypxkxxqcdfgpoxph
emilschn
reviewed
Jan 18, 2024
emilschn
reviewed
Jan 18, 2024
emilschn
reviewed
Jan 18, 2024
|
Je met en draft en attendant le fichier modifié qu'il prépare suite au premiers retours (warning sur les partenaire) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#1963
Description
Amélioration de la commande d'import des signalements (pour traitement des import du 67)
Changements apportés
Tests
make console app="import-signalement 67)