Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug notification si format de mail invalide #2129

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Jan 18, 2024

Ticket

#1807

Description

  • Fix d'un crash lors de la fermeture / réouverture d'un signalement avec notification si l'email enregistré n'est pas au bon format
  • Fix d'un warning quand FEATURE_NEW_FORM_ENABLE=1 sur des signalements qui n'ont pas de latitude/longitude

Tests

  • Sur copie de la base de prod fermer/réouvrir le signalement 2021-1754 sur dept 24
  • Sur copie de la bas de prod aller sur la fiche signalement du 2021-1729

@numew numew requested review from emilschn, hmeneuvrier and sfinx13 and removed request for emilschn and hmeneuvrier January 18, 2024 08:25
@numew numew changed the title manage notificationMailer Exception #1807 Fix bug notification si format de mail invalide Jan 18, 2024
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un retour.
Ok pour la relecture / test pour l'adresse e-mail

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK relecture et tests !

@sfinx13 sfinx13 merged commit 9455c61 into develop Jan 25, 2024
3 checks passed
@sfinx13 sfinx13 deleted the bugfix/1807-fix-validation branch February 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants