Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Signalement] Mettre à jour désordres, score de criticités et qualifications en cas d'édition du signalement #2146

Merged

Conversation

hmeneuvrier
Copy link
Collaborator

@hmeneuvrier hmeneuvrier commented Jan 26, 2024

Ticket

#2073

Description

Si la composition du logement est mise à jour, il faut recalculer les désordres liés à la composition du logement, et du coup recalculer le score, les qualifications et le tag suroccupation (ça, dans SignalementManager updateFromSituationFoyerRequest)

Changements apportés

  • Ajout de méthodes dans l'entité signalement
  • Création d'un service DesordreCompositionLogement pour calculer les désordres liés à la composition du logement
  • Dans SignalementManager, création d'une fonciont checkSuroccupation
  • Dans SignalementManager,à la mise à jour des informations de logement, de la composition du logement ou de la situation du foyer on appelle checkSuroccupation (si besoin), ou on appelle le service DesordreCompositionLogement, on recalcule le score et les qualifications
  • Dans SignalementBuilder, on utilise DesordreCompositionLogement
  • Ajout de tests
  • Quelques changements dans mise en forme des désordres dans le twig

Pré-requis

Tests

  • Faire un signalement avec le nouveau formulaire
  • Vérifier ses qualifications, désordres et score
  • Changer la situation du foyer et/ou la composition du logement
  • Vérifier la mise à jour des désordres, des qualifications (suroccupation par exemple) et du score

@hmeneuvrier hmeneuvrier force-pushed the feature/2073-bo-signalement-update-desordre-qualifications branch from 7dfe7fe to 9dea53f Compare January 26, 2024 09:38
}
}
!empty($data['situation']) && $signalement->setJsonContent($data['situation']);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mort supprimé

src/Controller/Back/SignalementController.php Outdated Show resolved Hide resolved
src/Manager/SignalementManager.php Outdated Show resolved Hide resolved
src/Manager/SignalementManager.php Outdated Show resolved Hide resolved
src/Manager/SignalementManager.php Outdated Show resolved Hide resolved
src/Manager/SignalementManager.php Outdated Show resolved Hide resolved
src/Manager/SignalementManager.php Outdated Show resolved Hide resolved
src/Service/Signalement/SignalementBuilder.php Outdated Show resolved Hide resolved
@hmeneuvrier hmeneuvrier force-pushed the feature/2073-bo-signalement-update-desordre-qualifications branch from 34b5625 to 76247a8 Compare January 29, 2024 13:59
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test et relecture OK

@sfinx13 sfinx13 merged commit 5ec7706 into develop Jan 30, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2073-bo-signalement-update-desordre-qualifications branch January 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants