Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Désordres] Affichage du type de chauffage #2187

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2166

Description

On affiche le type de chauffage sélectionné par l'usager

Changements apportés

  • Changement du SignalementBuilder pour enregistrer le type de chauffage dans jsonContent (comme on a fait pour la précision sur les nuisibles)
  • Modification du twig d'affichage de désordre pour afficher d'éventuels éléments liés à une catégorie de désordres.

Pré-requis

Tests

@hmeneuvrier hmeneuvrier linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un retour de code, mais tests OK !

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

48.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok, mais je me pose des questions sur L'enum

src/Entity/Enum/ChauffageType.php Show resolved Hide resolved
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et test

@emilschn emilschn merged commit 2ce9763 into develop Feb 2, 2024
2 of 3 checks passed
@sfinx13 sfinx13 deleted the feature/2166-bo-desordres-chauffageconfort-show-type-chauffage branch February 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BO - Désordres] Chauffage/Confort
3 participants