[Signalement] Modification de la question de préavis de départ #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilschn
commented
Feb 1, 2024
| @@ -101,6 +102,18 @@ public function setTravailleurSocialQuitteLogement(?string $travailleurSocialQui | |||
| return $this; | |||
| } | |||
|
|
|||
| public function getTravailleurSocialPreavisDepart(bool $raw = true): ?string | |||
| { | |||
| return (!$raw && 'nsp' === $this->travailleurSocialPreavisDepart) ? 'Ne sait pas' : $this->travailleurSocialPreavisDepart; | |||
There was a problem hiding this comment.
reprise du même principe utilisé par Numa dans sa PR #2194
emilschn
commented
Feb 1, 2024
| {% elseif signalement.situationFoyer.travailleurSocialPreavisDepart is same as 'non' %} | ||
| {{ static_picto_no|raw }} | ||
| {% else %} | ||
| {{signalement.situationFoyer.travailleurSocialPreavisDepart(false)}} |
There was a problem hiding this comment.
Reprise du principe utilisé par Numa dans sa PR #2194
hmeneuvrier
reviewed
Feb 2, 2024
templates/back/signalement/view/edit-modals/edit-situation-foyer.html.twig
Show resolved
Hide resolved
src/DataFixtures/Files/signalement_draft_payload/locataire.json
Outdated
Show resolved
Hide resolved
|
Quelques commentaires, tests pas encore faits |
|
@hmeneuvrier retours traités tableau mis à jour ligne 74 |
hmeneuvrier
approved these changes
Feb 6, 2024
emilschn
force-pushed
the
feature/2164-preavis-depart
branch
from
5006c96
to
7f1c473
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2164
Description
L'information sur le préavis de départ n'était pas obtenue avec la même précision selon les profils.
La question est posée ailleurs, si le déclarant sait si l'occupant a prévu de quitter les lieux.
Dans le BO, elle change de bloc.
Tests