Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relances auto] Correction requête pour ne pas exclure les abandons de procédures NULL #2206

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

emilschn
Copy link
Collaborator

@emilschn emilschn commented Feb 2, 2024

Ticket

#2181

Description

Certains signalements (voir ticket joint) ne recevaient pas de relance automatique.
Après étude, les signalements dont la valeur de is_usager_abandon_procedure était à NULL n'était pas retourné.
Etrangeté de MySQL qui ne considère pas les valeurs NULL dans != 1

Tests

  • Mettre is_usager_abandon_procedure à NULL pour un ou plusieurs signalements
  • Exécuter la commande make console app="ask-feedback-usager"
  • Vérifier que le signalement est bien concerné par les relances qui sont envoyées

src/Entity/Suivi.php Outdated Show resolved Hide resolved
@hmeneuvrier
Copy link
Collaborator

A part la limite, relecture OK et tests OK

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
On créé un ticket pour enlever la limite dans 4 ou 6 semaines ? ou on la garde ?

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@emilschn
Copy link
Collaborator Author

emilschn commented Feb 2, 2024

Ok. On créé un ticket pour enlever la limite dans 4 ou 6 semaines ? ou on la garde ?

Je crée un ticket en prio moyenne pour se poser la question

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test et relecture OK

@numew numew merged commit e679c2b into develop Feb 2, 2024
3 checks passed
@emilschn emilschn deleted the fix/2181-suivi-auto-query branch February 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants