Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixer des contraintes de longueur et de complexité des mots de passe #2224

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Feb 7, 2024

Ticket

#721 #2145

Description

Ajout de contraintes de validation pour des mot de passe plus fort :

  • 8 caractères minimum
  • 1 caractère majuscule minimum
  • 1 caractère minuscule minimum
  • 1 chiffre minimum
  • 1 caractère spécial minimum

Suppression de l'affichage de la modale CGU lors de la modification d'un mot de passe
Modification du mot de passe par défaut de la commande app:add-user pour matcher les contraintes

Tests

  • Vérifier que l'activation de compte / modification du mot de passe fonctionne correctement
  • Vérifier que les indicateurs de contrainte évoluent correctement au fur et à mesure de la complétion du champs
  • Vérifier que les contraintes sont bien vérifiées coté serveur (en soumettant des valeur incorrecte après avoir désactivé le javascript)

@numew numew marked this pull request as ready for review February 8, 2024 11:25
src/Entity/User.php Show resolved Hide resolved
public/js/app.js Outdated
@@ -963,32 +963,18 @@ document?.querySelectorAll('.fr-password-toggle')?.forEach(pwdToggle => {
})
})
document?.querySelector('form[name="login-creation-mdp-form"]')?.querySelectorAll('[name^="password"]').forEach(pwd => {
Copy link
Collaborator

@sfinx13 sfinx13 Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Déporter toute cette logique dans un nouveau fichier js dans assets/controllers. ll est prévu de supprimer app.js

public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et tests OK

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture + Test OK

@sfinx13 sfinx13 merged commit 04fec89 into develop Feb 12, 2024
3 checks passed
@sfinx13 sfinx13 deleted the feature/721-contraintes-mot-de-passe branch February 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants