Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Nouveau formulaire] Suppression du timeout à l'upload #2262

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Feb 20, 2024

Ticket

#2261

Description

Suite au rallongement de la durée du timeout sur l'upload, il y'a quelques evenements qui dépasse les 120s.
Un timeout sur un upload n'est pas adapté du aux différentes vitesse de connexion des uns et des autres.
La suite dans le thread suivant

Changements apportés

  • Suppression du timeout

Pré-requis

make npm build

Tests

image

  • Uploader en connexion lente plusieurs photos dans les désordres de sorte à dépasser les 120 secondes

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -37,7 +37,7 @@ export const requests = {
},
doRequestPostUpload (ajaxUrl: string, data: any, functionReturn: Function, config: any) {
const axiosInstance = axios.create({
timeout: 120000
timeout: 0 // TODO: va nécéssiter d'apporter quelques retouches sur l'UX
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et test

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et test OK

@hmeneuvrier hmeneuvrier merged commit 764dec7 into main Feb 20, 2024
3 checks passed
@sfinx13 sfinx13 deleted the hotfix/2261-remove-timeout-upload branch February 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants