Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG Notification] envoyer email de suivi unique quand email occupant et déclarant sont identique #2286

Conversation

numew
Copy link
Collaborator

@numew numew commented Feb 23, 2024

Ticket

#2282

Description

Lorsque l'email usager et déclarant d'un signalement est le même, une seule notification est envoyé à l'usager

Changements apportés

  • Modification de la fonction getMailUsagers du Signalement
  • Optimisation de quelques process d’envois d'email

Tests

  • Faire un signalement en tant que locataire et vérifier que les notifications de suivi sont bien unique
  • Faire un signalement en tant que tiers et vérifier que le déclarant et l’occupant continue d'être notifié séparément

Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture ok, tests OK (j'ai testé création de signalement occupant et tiers, suivi sur signalements nouveaux occupant et tiers et suivi sur signalements anciens occupants et tiers)

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lecture et test

@emilschn emilschn merged commit b0a5e30 into develop Feb 23, 2024
3 checks passed
@sfinx13 sfinx13 added v2.0.2 and removed v2.0.2 labels Mar 5, 2024
@hmeneuvrier hmeneuvrier deleted the feature/2282-notification-mail-unique-meme-declarant-occupant branch March 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants