-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BO - signalement] Erreur sur l'attribution de désordres liés à la composition du logement #2316
Merged
numew
merged 4 commits into
develop
from
bugfix/2312-bo-signalement-erreur-sur-la-prise-en-compte-de-superficie-etou-hauteur-sous-plafond
Mar 6, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfinx13
requested changes
Mar 5, 2024
9d6cff2
to
8186ccb
Compare
numew
reviewed
Mar 5, 2024
735984d
to
b837751
Compare
sfinx13
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lecture et test OK
|
numew
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2312
Description
Après analyse, pour le problème des désordres liés à la composition du logement, on affectait les désordres au signalement si la réponse à certaines questions était différente de "oui". Je change ce fonctionnement pour n'avoir le désordre que si on répond "non".
Changements apportés
Pré-requis
Avant de descendre la branche :
Faire un signalement en tiers (si possible tiers pro car il manque une question), et répondre le plus possible "je ne sais pas" (pour hauteur, pièce 9m, wc, sdb et cuisine)
Vérifier que les désordres liés apparaissent dans la liste
Editer un signalement fait avec l'ancien formulaire. Editer la composition du logement.
Vérifier en base que ce signalement se retrouve lié à des desordrePrecision, desordreCritere, desordreCategorie
Descendre la branche
make composer
Tests
make console app="update-signalement-desordres"