Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FO - Fiche signalement] Documents non accessible pour usagers #2318

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[FO - Fiche signalement] Documents non accessible pour usagers #2318

merged 1 commit into from
Mar 6, 2024

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Mar 5, 2024

Ticket

#2317

Description

Permet la visualisation des documents pour les usagers (voir thread mattermost pour le choix technique)
Régression https://github.com/MTES-MCT/histologe/releases/tag/2.0.2

Changements apportés

  • Mise à jour du voter
  • Mise à jour des templates afin que la route soit la même que les agents

Pré-requis

Tests

  • En tant qu'agent, sur la fiche signalement ajouter des photos et des suivi avec documents
  • En tant qu'usager sur la fiche de suivi ajouter des photos

@sfinx13 sfinx13 force-pushed the hotfix/2317-document-no-visible-usager branch from 0967eec to f611146 Compare March 6, 2024 08:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

hmeneuvrier
hmeneuvrier approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test et relecture OK

@hmeneuvrier hmeneuvrier mentioned this pull request Mar 6, 2024
Merged
5 tasks
numew
numew approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@numew numew merged commit 4cbc01d into main Mar 6, 2024
2 of 3 checks passed
@sfinx13 sfinx13 deleted the hotfix/2317-document-no-visible-usager branch March 6, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numew numew numew approved these changes

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@emilschn emilschn Awaiting requested review from emilschn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfinx13 @numew @hmeneuvrier