Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Oilhi] Supprimer champs problématiques à l'enregistrement Airtable #2324

Merged
merged 2 commits into from
Mar 8, 2024
Merged

[Oilhi] Supprimer champs problématiques à l'enregistrement Airtable #2324

merged 2 commits into from
Mar 8, 2024

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Mar 7, 2024 •
edited
Loading

Ticket

#2323

Description

Les champs non mappés bloquent l'enregistrement sur Airtable

Changements apportés

  • Suppression des champs partnerId et signalementId
  • Suppression du html des précisions

Pré-requis

  • Mise à jour du keepass
  • Récupérer les identifiants Zapier
  • Activer Oilhi et récupérer autres variables d'environnements
FEATURE_OILHI_ENABLE=1 
ZAPIER_OILHI_TOKEN=
ZAPIER_OILHI_USER_ID=
ZAPIER_OILHI_CREATE_AIRTABLE_RECORD_ZAP_ID=
  • make worker-start

Tests

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

emilschn
emilschn approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lecture et test !

numew
numew approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@numew numew merged commit a7fa2ba into develop Mar 8, 2024
3 checks passed
@sfinx13 sfinx13 deleted the bugfix/2323-oilhi-remove-useless-fields branch March 11, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn approved these changes

@numew numew numew approved these changes

@hmeneuvrier hmeneuvrier Awaiting requested review from hmeneuvrier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfinx13 @emilschn @numew