-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FO - Signalement] Autocomplétion Bailleur social #2329
Conversation
f0b2cef
to
56742be
Compare
assets/vue/components/signalement-form/components/SignalementFormAutocomplete.vue
Outdated
Show resolved
Hide resolved
/> | ||
|
||
<div class="fr-grid-row fr-background-alt--blue-france fr-text-label--blue-france fr-autocomplete-group"> | ||
<div class="fr-col-12 fr-p-3v fr-text-label--blue-france fr-autocomplete-suggestion" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible de remplacer par un <select>
en multiline
, pour pouvoir utiliser le clavier nativement ?
j'avais fait comme ça pour les adresses sur Punaises, même si je crois qu'il y a des retours dessus qu'on n'a pas encore traité :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vu en stand up
- implémentation de la navigation au clavier OK
- Fermeture de la liste sur un clic extérieur à la zone de suggestion
Implémentation pour le rendre 100% accessible avec les balise aria demande plus de temps (plusieurs attributs à gérer)
Voir => https://alphagov.github.io/accessible-autocomplete/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prise en charge dans le ticket des attributs (aria-*)
, tabindex
etc...
#2341
assets/vue/components/signalement-form/components/SignalementFormAutocomplete.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques retours. Pas encore testé.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelque remarques en attendant le changement de structure
assets/vue/components/signalement-form/components/SignalementFormAutocomplete.vue
Show resolved
Hide resolved
assets/vue/components/signalement-form/components/SignalementFormAutocomplete.vue
Show resolved
Hide resolved
b957ef4
to
d981700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques retours et propositions.
1 Test KO : Si on modifie la valeur dan le BO en rentrant une valeur libre l'id bailleur n'est pas modifié
Petites remarque :
@numew
|
0e8a26b
to
f8f9771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un retour de test bloquant
En tant que particulier sans logement social, on ne me propose pas la liste des bailleurs OK
Mais par contre, je ne peux pas passer à l'écran suivant KO.
Ok pour le test KO qui a été corrigé, je n'ai pas vu de différence sur les autres points |
@numew la cette fois ci c'est bon :-D |
Retour bloquant traité @hmeneuvrier @numew |
Test KO Tous les autres sont OK |
Quality Gate passedIssues Measures |
tools/wiremock/src/Resources/Signalement/questions_profile_locataire.json
Show resolved
Hide resolved
tools/wiremock/src/Resources/Signalement/questions_profile_locataire.json
Show resolved
Hide resolved
Tests OK maintenant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK pour moi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Ticket
#2215
Description
Ajout d'une liste de bailleurs en auto-complétion si c'est un logement social.
Changements apportés
Prérequis
Le fichier est déjà sur le bucket
Tests
make console app="import-bailleur"