Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mettre en œuvre une procédure de suppression des comptes inactifs #2336

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Mar 15, 2024

Ticket

#720

Description

  • Ajout d'une page admin permettant d'afficher les comptes inactifs (agents sans connexion depuis + de 11 mois, non archivé)
  • Ajout d'une page admin permettant d'afficher Les compte expirés (+ de 2 ans sans activité pour les agent / plus de 5 ans pour les users)
  • Ajout d'une commande permettant de notifier les comptes inactifs (30 jours avant suppression et 7 jours avant suppression) et de les archiver si ils sont toujours sans connexion 30 jours après la première notification.
  • Lancement de la commande par cron une fois (et une seule fois !) par jour

Pré-requis

make execute-migration name=Version20240318123747 direction=up

Tests

  • Vérifier que les pages admin s'affiche correctement
  • Vérifier le fonctionnement de la commande make console app="notify-and-archive-inactive-accounts"

@numew numew marked this pull request as ready for review March 18, 2024 16:51
@numew numew requested review from sfinx13, emilschn and hmeneuvrier and removed request for sfinx13 March 18, 2024 16:51
src/Entity/User.php Show resolved Hide resolved
src/Entity/User.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Des petits ajustements front, en plus des coms de Saidi

src/Repository/UserRepository.php Outdated Show resolved Hide resolved
src/Repository/UserRepository.php Show resolved Hide resolved
src/Repository/UserRepository.php Show resolved Hide resolved
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK, prendre en compte la remarque d’Émilien sur la limite légale,
ça serait bien d'ajouter un compte inactif et un compte expiré dans les fixtures

@numew numew marked this pull request as draft March 25, 2024 15:44
@numew numew marked this pull request as ready for review March 29, 2024 08:27
@numew
Copy link
Collaborator Author

numew commented Mar 29, 2024

Lecture et test OK, prendre en compte la remarque d’Émilien sur la limite légale, ça serait bien d'ajouter un compte inactif et un compte expiré dans les fixtures

Ok, c'est fait

templates/emails/account_soon_archived_email.html.twig Outdated Show resolved Hide resolved
templates/back/nav_bo.html.twig Show resolved Hide resolved
templates/back/nav_bo.html.twig Outdated Show resolved Hide resolved
templates/back/expired-account/index.html.twig Outdated Show resolved Hide resolved
templates/back/expired-account/index.html.twig Outdated Show resolved Hide resolved
templates/back/inactive-account/index.html.twig Outdated Show resolved Hide resolved
templates/back/inactive-account/index.html.twig Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !!

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit fa76b07 into develop Apr 3, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/720-remove-innactive-accounts branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants