Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ouverture Guyane #2354

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[Bug] ouverture Guyane #2354

merged 1 commit into from
Mar 22, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Mar 21, 2024

Ticket

#2353

Description

Ajout des code DOM/TOM dans le ZipcodeProvider

Tests

  • Possibilité d'ajouter un signalement en Guyane

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@numew numew changed the title [Bug] ouverture Guyanne [Bug] ouverture Guyane Mar 21, 2024
public const LA_REUNION_CODE_DEPARTMENT_974 = '974';
public const ST_PIERRE_ET_MIQUELON_CODE_DEPARTMENT_975 = '975';
public const MAYOTTE_CODE_DEPARTMENT_976 = '976';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans notre liste de territoires, on s'arrête à Mayotte, je ne sais pas si ça vaut le coup de mettre les autres ? (puisque de toutes façons pour les ouvrir il faudra passer par une migration et une mise à jour des fixtures)

Sinon j'ai fait les tests et c'est ok pour moi

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'approuve

@hmeneuvrier hmeneuvrier merged commit 6701587 into main Mar 22, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the hotfix/2353-ouverture-guyane branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants