Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Sujets des notifications #2364

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[Bug] Sujets des notifications #2364

merged 1 commit into from
Mar 22, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Mar 22, 2024 •
edited by emilschn
Loading

Ticket

#2360

Description

  • Modification du lien dans le mail "Date de visite à renseigner" qui pointe maintenant vers la fiche du signalement en BO au lieu de FO
  • Modification des mail utilisant des sujets dynamique pour que le sujet change bien lors d'envoi multiple d'email de même type sur des signalements différents
  • Ajout d'une fixture et d'un test permettant de vérifier le second point

Tests

  • Ouvrir mailcatcher, lancer make console app="notify-visits" et vérifier qu'il y'a bien deux sujet différents sur les 4 notification de type "Date de visite à renseigner"

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

emilschn
emilschn approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lecture et tests

hmeneuvrier
hmeneuvrier approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et tests OK

@hmeneuvrier hmeneuvrier merged commit 2ad666b into main Mar 22, 2024
2 of 3 checks passed
@hmeneuvrier hmeneuvrier deleted the hotfix/2360-notification-dae-visite branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn approved these changes

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@sfinx13 sfinx13 Awaiting requested review from sfinx13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@numew @emilschn @hmeneuvrier