[QA] Conversion en nombre entier pour le nombre de personnes #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmeneuvrier
approved these changes
Mar 25, 2024
sfinx13
requested changes
Mar 25, 2024
| if (!empty($compositionLogementNombrePersonnes) && is_numeric($compositionLogementNombrePersonnes)) { | ||
| $compositionLogementNombrePersonnes = ceil($compositionLogementNombrePersonnes); | ||
| } | ||
|
|
||
| $this->signalement | ||
| ->setTypeCompositionLogement( | ||
| $this->typeCompositionLogementFactory->createFromSignalementDraftPayload($this->payload) |
There was a problem hiding this comment.
A corriger aussi dans le champs type_composition_logement
Le plus efficace serait de gérer ça dans le normalizer
|
hmeneuvrier
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2251
Description
Certaines personnes saisissent un nombre float pour le nombre de personnes (Ex : 3.5). On l'arrondit à l'entier supérieur.
Le ticket signale une autre conversion, mais elle a été corrigée par ailleurs.
Tests
EDIT