Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cron Esabora #2376

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[Bug] cron Esabora #2376

merged 2 commits into from
Mar 25, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Mar 25, 2024

Ticket

#2374

Description

  • Gestion des erreur PHP et exception dans la SynchronizeInterventionSISHCommand.php
  • Gestion spécifique du cas des visites sans dates retournés par Esabora (lève une exception)

Tests

  • Sur une copie de la base de prod exécuter make console app="sync-esabora-sish-intervention 87446c3c-821c-4e16-8329-5edbd2496161" et vérifier que le script ne crashe plus malgré l'erreur de date
  • Provoquer une erreur PHP (ex ajout de la ligne 100/0; dans le bloc try de SynchronizeInterventionSISHCommand) et vérifier que le script ne crashe pas

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

if (!$dossierVisite->getVisiteDate()) {
$hasDateError = true;
$hasSuccess = false;
continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il ne serait pas possible dans ce cas d'enregistrer l'erreur en base pour qu'elle s'affiche aussi dans le dashboard ?

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit e1588f2 into main Mar 25, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the hotfix/2374-bug-cron-esabora branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants