Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FO] Ajustements UI nouvelles pages #2396

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2384
#2385
#2386
#2387
#2389

Description

Ajustements mineurs sur contenus

Changements apportés

  • page obligations locataire proprio] Mauvais texte
  • page contact] Modifier le title
  • page aides] Ajouter icône lien externe
  • pages obligations et aides] Revoir les marges entre les listes et paragraphes (je n'ai pas pu baisser l'espace entre le début d'une liste et la liste, du coup j'ai surtout espacé les listes.)
  • page aides] Formater la liste

Pré-requis

npm run build

Tests

  • Vérifier les différentes pages en regardant les tickets
  • s'assurer qu'il n'y ait pas un tooltip qui a disparu

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est le même retour à chaque fois
https://caninclude.glitch.me/caninclude?child=ul&parent=p

templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
templates/front/obligations_entretien.html.twig Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me suis permis d'adapter les espacement (vu avec mathilde) et de les généralisé via css + une correction de ul dans un p qu'il restait.
Ok pour moi

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit 857d5ec into develop Mar 28, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2384-2385-2385-2387-2389-fo-nouvelles-pages branch April 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants