Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FO - home et contact] Afficher la sélection dans le champ adresse #2400

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2383

Description

Afficher la sélection dans le champ adresse sur les pages accueil et contact

Changements apportés

  • Correction du js pour ne pas attacher les fonctions d'autocomplete à la div parente de l'input qui a aussi l'attribut data-fr-adresse-autocomplet

Pré-requis

Tests

  • Tester sur les deux pages le composant d'autocomplete, le champ input doit bien avoir la valeur de l'adresse choisie quand on clique sur une des propositions

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Désolé j'ai préféré modifier l'erreur source sur le form theme (le attribut de l'imput ne doivent pas se retrouver sur le parent)

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et retest OK

@sfinx13 sfinx13 merged commit 7507b03 into develop Mar 28, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2383-fo-home-et-contact-afficher-la-selection-dans-le-champ-adresse branch April 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants