-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BO - Liste signalement][Back] Gestion liste et filtre existants signalements sous format JSON #2408
Conversation
b3a2adb
to
d470e3f
Compare
d470e3f
to
80d0873
Compare
Tests OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques remarques/questions, mais ca fonctionne, test ok
private readonly ?string $typeDeclarant = null, | ||
#[Assert\Choice(['privee', 'public'])] | ||
private readonly ?string $natureParc = null, | ||
#[Assert\Choice(['caf', 'msa', 'non'])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il manque pas un choix "oui" ?
C'est top de valider les données par contre pour l'instant les erreur ne sont pas gérés (ici si j'envoie oui j'ai une exception qui est levé)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bien qu'il ne soit pas spécifié, je suis d'accord de l'ajouter vu qu'il en existe en base (données historiques)
Pour les exceptions, vu l'usage qui se fera uniquement dans le BO via des listes, on peut s'en tenir au comportement par défaut (erreur 404)
EDIT
Je pourrais creuser plus tard pour la gestion des erreurs mais c'est pas bloquant pour la PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathildepoulpux on a des signalements qui ont pour valeur oui
pour allocataire. Ok pour ajouter la valeur dans le filtre ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui on peut !
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-relecture et re-tests OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Ticket
#2117
Description
Sur la base des données et filtres existants, la nouvelle route doit fournir la liste au format JSON triable et filtrable selon les specs
https://github.com/MTES-MCT/histologe/wiki/liste-signalements
Changements apportés
http://localhost:8080/bo/list/signalements/?page=1&commune=13002
http://localhost:8080/bo/list/signalements/?page=1&partenaires[]=AUCUN
Tests de non regression
Tests
pagination
,list
,filters
)- http://localhost:8080/bo/list/signalements/?page=1&sortBy=createdAt&orderBy=DESC
- http://localhost:8080/bo/list/signalements/?page=1&sortBy=nomOccupant&orderBy=DESC
- http://localhost:8080/bo/list/signalements/?page=1&sortBy=reference&orderBy=DESC