Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email de notification usager "Une visite de votre logement est prévue" #2409

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix email de notification usager "Une visite de votre logement est prévue" #2409

merged 1 commit into from
Apr 4, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Apr 2, 2024

Ticket

#2407

Description

L'email de notification usager "Une visite de votre logement est prévue" est envoyé uniquement si :

  • Le type de l'intervention est VISITE
  • La date est dans le futur

Changements apportés

  • Ajout de test permettant de vérifier que les mails ne sont pas envoyés quand les conditions ne sont pas réunis

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sfinx13
sfinx13 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour le test

  1. Executer make sync-sish
  2. Regarder les intervention ajouté(s) suite à la commande (ARRETE_PREFECTORALE ET VISITE_CONTROLE)
  3. Regarder la boite mailmatcher (aucun mail de visite programmé)

Lecture et test OK

hmeneuvrier
hmeneuvrier approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et test OK

@hmeneuvrier hmeneuvrier merged commit e243ecf into main Apr 4, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the hotfix/2407-controle-intervention-notif branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfinx13 sfinx13 sfinx13 approved these changes

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@emilschn emilschn Awaiting requested review from emilschn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@numew @sfinx13 @hmeneuvrier