Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] mail null / delete notif... #2427

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Apr 8, 2024

Ticket

#2424

Description

  1. Tentative d’envois de notification mail avec email destinataire null
    https://sentry.incubateur.net/organizations/betagouv/issues/86812/?project=61&query=is%3Aunresolved&referrer=issue-stream
    -> Correction du repository

  2. Crash lors de la tentative de suppression d'une notification inexistante
    https://sentry.incubateur.net/organizations/betagouv/issues/85062/events/1ac7f41525b6413482edf178ce3005fb/?project=61
    -> Redirection vers la liste plutôt que page d'erreur

  3. Warning: file_get_contents(xxx): Failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found
    https://sentry.incubateur.net/organizations/betagouv/issues/95280/?project=61&query=is%3Aunresolved&referrer=issue-stream
    -> Utilisation du fileExist

  4. Crash export csv
    https://sentry.incubateur.net/organizations/betagouv/issues/85056/?project=61&query=is%3Aunresolved&referrer=issue-stream
    -> Ajout d'info de debug pour les prochaines occurences

Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture OK, test pour les notifications OK, je ne sais pas trop comment tester le reste

@hmeneuvrier hmeneuvrier merged commit b386974 into main Apr 8, 2024
2 of 3 checks passed
@hmeneuvrier hmeneuvrier deleted the hotfix/2424-fix-send-mail-with-null-email branch April 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants