Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Ajout photos situation] Ne pas uploader les photos aux formats non pris en charge #2451

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Apr 10, 2024

Ticket

#2435

Description

Contrôle du format des photo envoyé via la modale d'upload de photos, pour restreindre uniquement au jpg, png et gif.

Pré-requis

make npm-build

Tests

  • Tester l'envoie d'une photo webp via le glisser déposer dans la modale d'upload d'ajout de photo et vérifier qu'un message d'erreur est affiché.

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et test OK

@hmeneuvrier
Copy link
Collaborator

@numew j'ai testé trop vite, on a curieusement l'erreur si on veut ajouter des documents
image

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@numew
Copy link
Collaborator Author

numew commented Apr 15, 2024

@numew j'ai testé trop vite, on a curieusement l'erreur si on veut ajouter des documents image

Oui, j'avais fait ca un peu trop rapidement, c'est corrigé

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette fois-ci c'est vraiment ok pour moi :) on ne peut pas ajouter des webp, heic ou pdf pour l'ajout de photos, mais on peut en mettre pour les documents.

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et tests

@emilschn emilschn merged commit c0cd9ec into develop Apr 15, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2435-limit-image-format branch April 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants