Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BO - Modale ajout documents] Amélioration de la modale (UX et contenu) #2456

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[BO - Modale ajout documents] Amélioration de la modale (UX et contenu) #2456

merged 2 commits into from
Apr 16, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2440

Description

  • Ajouter une marge avant le message warning
  • Ajouter le texte Pour ajouter des documents concernant la procédure ou le bailleur, rendez-vous dans la partie "Documents partenaires". (cf. specs)
  • Modifier le message warning pour Ces documents seront partagés à l'usager.
  • Modifier l'ordre des éléments dans la liste déroulante des types de documents pour que "Photo de désordre" soit en avant dernier et "Autre" en dernier"

Changements apportés

  • Changement des twig et des document types

Pré-requis

Tests

  • Ouvrir les modales d'upload de photos (situation et visite) et de documents (situation et partenaire) et vérifier la correction des points ci-dessus

emilschn
emilschn approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et tests

sfinx13
sfinx13 requested changes Apr 15, 2024
View reviewed changes
src/Entity/Enum/DocumentType.php Outdated Show resolved Hide resolved
@hmeneuvrier hmeneuvrier force-pushed the bugfix/2440-bo-modale-ajout-documents-ux branch from fb70833 to 943bf0c Compare April 16, 2024 09:39
@hmeneuvrier hmeneuvrier force-pushed the bugfix/2440-bo-modale-ajout-documents-ux branch from 15a89ba to 3a6b5bc Compare April 16, 2024 12:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sfinx13
sfinx13 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit 8e524ca into develop Apr 16, 2024
2 of 3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2440-bo-modale-ajout-documents-ux branch April 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn approved these changes

@sfinx13 sfinx13 sfinx13 approved these changes

@numew numew Awaiting requested review from numew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hmeneuvrier @emilschn @sfinx13