Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] unpkg plus fiable #2462

Merged
merged 3 commits into from
Apr 15, 2024
Merged

[QA] unpkg plus fiable #2462

merged 3 commits into from
Apr 15, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

@hmeneuvrier hmeneuvrier commented Apr 12, 2024

Ticket

#2461

Description

Changement de cdn pour les librairies js leaflet, popper et tippy

Changements apportés

  • Changement de cdn
  • Ajout du nouveau cdn dans la security csp header

Pré-requis

[edit] Modifier SECURITY_CSP_HEADER_VALUE dans .env.local

Tests

  • Vérifier l'affichage de la page de signalement, et l'utilisation des tags
  • Vérifier l'affichage de la cartographie

@hmeneuvrier hmeneuvrier linked an issue Apr 12, 2024 that may be closed by this pull request
@hmeneuvrier
Copy link
Collaborator Author

⚠️ après merge, mettre à jour la variable SECURITY_CSP_HEADER_VALUE en prod et sur la staging

{% endif %}
{% if 'back_signalement_view' in app.request.get('_route') %}
<script src="https://unpkg.com/@popperjs/core@2"></script>
<script src="https://unpkg.com/tippy.js@6"></script>
<script src="https://cdn.jsdelivr.net/npm/@popperjs/core@2.11.8/dist/umd/popper.min.js"></script>
Copy link
Collaborator Author

@hmeneuvrier hmeneuvrier Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'avais d'abord essayé, mais des erreurs "exports is not defined"

<script src="https://cdn.jsdelivr.net/npm/@popperjs/core@2"></script>
<script src="https://cdn.jsdelivr.net/npm/tippy.js@6"></script>

<link rel="stylesheet" href="https://unpkg.com/leaflet@1.7.1/dist/leaflet.css"/>
<link rel="stylesheet" href="https://unpkg.com/leaflet.markercluster@1.5.3/dist/MarkerCluster.Default.css"/>
<link rel="stylesheet" href="https://unpkg.com/leaflet.markercluster@1.5.3/dist/MarkerCluster.css"/>
{% if 'back_cartographie' in app.request.get('_route') %}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaflet n'est plus utilisé sur la page de signalement

{% if 'back_cartographie' in app.request.get('_route') or 'back_signalement_view' in app.request.get('_route') %}
<script src="https://unpkg.com/leaflet@1.7.1/dist/leaflet.js"></script>
<script src="https://unpkg.com/leaflet.markercluster@1.5.3/dist/leaflet.markercluster.js"></script>
{% if 'back_cartographie' in app.request.get('_route') %}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaflet n'est plus utilisé sur la page de signalement

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test ok
J'ai ajouté un com dans les pré-requis de la PR.
Il faut régler SonarCloud

.env Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit bdee7a0 into main Apr 15, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the hotfix/2461-qa-unpkg-plus-fiable branch April 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] unpkg plus fiable
3 participants