Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Signalement] Ajouter la modale de suppression de fichiers et la possibilité de supprimer les photos de visite #2463

Merged

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2445
#2448

Description

Ajout d'une modale pour valider la suppression d'un document ou d'une photo
Il faudrait ajouter la possibilité de supprimer des photos de visite, au cas où il y a des erreurs.

Changements apportés

  • Création d'une modale de suppression de fichier (twig et js)
  • Utilisation de cette modale pour les documents et photos, et aussi pour les photos de visite (ajout du bouton car les photos de visite n'étaient pas du tout supprimables)
  • Modification de la route de suppression de fichier pour utiliser le fileId plutôt que le filename et le type

Pré-requis

Tests

  • Tester avec différents utilisateurs et sur différents signalements de supprimer des documents partenaires, des documents de situation, des photos de situation ou des photos de visite

@hmeneuvrier hmeneuvrier requested review from sfinx13, emilschn and numew and removed request for emilschn April 12, 2024 21:19
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK test et relecture.
Petite typo.

@hmeneuvrier hmeneuvrier force-pushed the bugfix/2445-2448-bo-signalement-modale-suppression-file branch from c7e82e2 to 21e4c10 Compare April 16, 2024 10:19
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !

@hmeneuvrier hmeneuvrier force-pushed the bugfix/2445-2448-bo-signalement-modale-suppression-file branch from 3992253 to cb7bc2a Compare April 16, 2024 14:29
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

document.querySelector('#fileDescription').value = target.getAttribute('data-description')
document.querySelector('#fr-modal-edit-file-description').classList.remove('fr-hidden')
} else {
document.querySelector('#fr-modal-edit-file-description').classList.add('fr-hidden')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction d'un bug détecté par Emilien sur une autre PR pour ne pas avoir des descriptions pour les documents

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests et relecture OK

@numew numew merged commit 66e54ab into develop Apr 17, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2445-2448-bo-signalement-modale-suppression-file branch April 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants