[FO / BO - Signalement] Auteur document & photo non identifié quand ajout depuis formulaire #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numew
reviewed
Apr 22, 2024
src/Messenger/MessageHandler/SignalementDraftFileMessageHandler.php
Outdated
Show resolved
Hide resolved
hmeneuvrier
force-pushed
the
bugfix/2450-2447-fo-bo-signalement-auteur-document-photo-and-fix-suivi
branch
from
e8d0e80
to
79dc7b4
Compare
sfinx13
reviewed
Apr 24, 2024
There was a problem hiding this comment.
que c'était fait avec l'appel à $this->fileManager->updateSignalementFilesUser dans le SignalementCreatedSubscriber donc je suis un peu dubitative
- C'est depuis que les fichiers sont ajouté en async du coup cette ligne ne sert plus
- Ajout d'une migration (vu sur mattermost)
hmeneuvrier
force-pushed
the
bugfix/2450-2447-fo-bo-signalement-auteur-document-photo-and-fix-suivi
branch
from
5a01295
to
52ed0c9
Compare
numew
approved these changes
Apr 25, 2024
src/Messenger/MessageHandler/SignalementDraftFileMessageHandler.php
Outdated
Show resolved
Hide resolved
hmeneuvrier
force-pushed
the
bugfix/2450-2447-fo-bo-signalement-auteur-document-photo-and-fix-suivi
branch
from
ce7b55c
to
29acdf4
Compare
|
sfinx13
approved these changes
Apr 26, 2024
hmeneuvrier
deleted the
bugfix/2450-2447-fo-bo-signalement-auteur-document-photo-and-fix-suivi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2450 : [FO / BO - Signalement] Auteur document & photo non identifié quand ajout depuis formulaire
#2447 : [BO - Signalement] Erreur suivi auto de suppression document situation et partenaire
Description
Correction du suivi de suppression de documents
Ajout de l'utilisateur sur les fichiers ajoutés depuis le formulaire (mais honnêtement j'étais persuadée que ça fonctionnait )
Changements apportés
$this->fileManager->updateSignalementFilesUserdans le SignalementCreatedSubscriber donc je suis un peu dubitativePré-requis
Tests