Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sécurité - Login] Ne pas activer par défaut les user avec ROLE_USAGER #2535

Merged
merged 1 commit into from
May 6, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented May 6, 2024

Ticket

#2032

Description

  • Les utilisateur USAGER restent au STATUS_INACTIVE à la création
  • La commande app:remind-inactive-user exclus les utilisateur de ROLE_USAGER
  • Le système de login, permet le login des user au STATUS_ACTIVE uniquement

Tests

  • Vérifier que le fait de laisser les usager au STATUS_INACTIVE n'a pas d'impact sur le fonctionnement général

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et tests OK

Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'après ma relecture et mes recherches, ça me semble ok.
Mais je suis surpris de pourquoi on avait passé les USAGER en ACTIVE par défaut.
En regardant l'historique, ce n'était pas une correction. Donc ça a toujours été le cas, a priori.
Bref, ok pour moi !

@emilschn emilschn merged commit 80d09e0 into develop May 6, 2024
3 checks passed
@sfinx13 sfinx13 deleted the feature/2032-usager-inactif-par-defaut branch May 7, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants