Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Déplacer les json de formulaire vers un autre emplacement #2538

Merged
merged 1 commit into from
May 13, 2024
Merged

[QA] Déplacer les json de formulaire vers un autre emplacement #2538

merged 1 commit into from
May 13, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

@hmeneuvrier hmeneuvrier commented May 7, 2024 •
edited
Loading

Ticket

#2393

Description

Déplacement des json

Changements apportés

  • Déplacemment des json
  • Modification de webpack
  • Suppression des mocks
  • ignorer le dossier tools pour ne pas l'embarquer pour le déploiement via .slugignore

Pré-requis

npm run watch

Tests

  • Vérifier que le formulaire fonctionne toujours

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sfinx13
sfinx13 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK
j'ai aussi testé que le serveur de mock mock-start et make mock-stop

emilschn
emilschn approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et tests

@emilschn emilschn merged commit 4914f77 into develop May 13, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2393-qa-move-json-form branch June 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn approved these changes

@sfinx13 sfinx13 sfinx13 approved these changes

@numew numew Awaiting requested review from numew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hmeneuvrier @emilschn @sfinx13