Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FO - Formulaire] Correction pour archiver un draft existant #2563

Merged
merged 2 commits into from
May 17, 2024

Conversation

emilschn
Copy link
Collaborator

Ticket

#2559

Description

Lorsqu'un doublon de draft est détecté et qu'on souhaite archiver le précédent, la variable utilisée pour l'identifiant n'est pas la bonne et retourne null.

Tests

  • Créer un signalement en utilisant l'adresse et le mail d'un existant. Lorsque la modale s'affiche, choisir d'archiver. Vérifier que l'ancien signalement est bien archivé.

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rohlolo... j'avais oublié de changer cet uuid... la nulle... en tous cas je valide, lecture et tests !

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prendre en compte l'alerte sonar, on a le bloc if et le bloc else qui font la même chose

@emilschn emilschn force-pushed the fix/2559-archive-draft-null branch from bcc2f54 to 9bed71b Compare May 16, 2024 08:11
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@emilschn
Copy link
Collaborator Author

Prendre en compte l'alerte sonar, on a le bloc if et le bloc else qui font la même chose

Bien vu, c'est corrigé ! :)

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit 1a1696b into develop May 17, 2024
3 checks passed
@emilschn emilschn deleted the fix/2559-archive-draft-null branch May 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants