Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visites] Notifications aux autres partenaires affectés #2565

Merged
merged 4 commits into from
May 21, 2024

Conversation

emilschn
Copy link
Collaborator

Ticket

#2562

Description

Dans les spécifications des notifications de visite (https://github.com/MTES-MCT/histologe/wiki/Notifications), il est précisé que pour certains événements, tous les partenaires affectés doivent être notifiés (en dehors du partenaire en cours).
Cela n'avait pas été fait jusque-là.

Changements apportés

  • Reprise de la liste des événements, et pour les cas où les autres partenaires doivent être notifiés, ajout d'un paramètre spécifique

Tests

@hmeneuvrier
Copy link
Collaborator

J'ai créé la visite : seul l'utilisateur reçoit un mail, ce qui ne m'étonne pas car tu passes null comme notificationMailerType.
Par contre lors de la conclusion de visite c'est OK.
Il y a d'autres événements qui n'ont ppas non plus de notificationMailerType alors que tu as mis true pour notifyOtherAffectedPartners

@emilschn emilschn force-pushed the fix/2562-visite-conclusion-notifications branch from 8fd3010 to 45fd05d Compare May 16, 2024 08:21
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests et relecture OK

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture OK

@hmeneuvrier hmeneuvrier merged commit 579a146 into develop May 21, 2024
3 checks passed
@emilschn emilschn deleted the fix/2562-visite-conclusion-notifications branch May 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants