[BUG] corriger envoie de requêtes nouveau formulaire #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numew
requested review from
emilschn,
sfinx13 and
hmeneuvrier
and removed request for
emilschn and
sfinx13
emilschn
reviewed
May 29, 2024
| (formStore.data.vos_coordonnees_occupant_email !== undefined || | ||
| formStore.data.vos_coordonnees_tiers_email !== undefined) | ||
| ) { | ||
| if (formStore.currentScreen && formStore.currentScreen.slug !== 'adresse_logement' && formStore.currentScreen.slug !== 'signalement_concerne') { |
There was a problem hiding this comment.
on peut mettre cette condition dans une fonction ?
emilschn
reviewed
May 29, 2024
| this.isTyping = true | ||
| clearTimeout(this.idFetchTimeout) | ||
| this.idFetchTimeout = setTimeout(() => { | ||
| this.isTyping = false | ||
| requests.validateAddress(search, this.handleUpdateInsee) | ||
| }, 300) | ||
| }, 2000) |
There was a problem hiding this comment.
C'est un peu long :)
Si on choisit un lieu hors territoire ouvert, et qu'on clique sur suivant avant la popup (2 secondes + temps de la requête), on ne voit jamais la popup. (j'ai fait le test)
Je comprends le côté frustrant avec 300ms. Mais il faut raccourcir :)
|
emilschn
approved these changes
May 30, 2024
hmeneuvrier
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2595
Description
Tests