[BO - Filtre signalement] Correction tri #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfinx13
commented
May 31, 2024
| @@ -172,9 +172,9 @@ export default defineComponent({ | |||
| } | |||
| @@ -95,7 +95,7 @@ export const requests = { | |||
| // TODO : il y a sûrement plus élégant à faire pour construire l'url (cf controlleur et twig) | |||
| foreach ($signalements as $signalement) { | ||
| $createdAtUpdated = $signalement->getCreatedAt()->modify('+'.$second.' second'); |
There was a problem hiding this comment.
Pour test tri date de dernier suivi avec fixtures (pour avoir quelques dates différentes :-) )
sfinx13
commented
May 31, 2024
| private readonly string $sortBy = 'reference', | ||
| private readonly string $orderBy = 'DESC', | ||
| ) { | ||
| } | ||
|
|
||
| public function getTerritoires(): ?array | ||
| public function getTerritoire(): ?string |
There was a problem hiding this comment.
S'en tenir à la spec liste déroulante simple et non multiple
emilschn
reviewed
Jun 3, 2024
assets/vue/components/signalement-list/TheSignalementAppList.vue
Outdated
Show resolved
Hide resolved
emilschn
reviewed
Jun 3, 2024
assets/vue/components/signalement-list/components/SignalementListFilters.vue
Outdated
Show resolved
Hide resolved
emilschn
reviewed
Jun 3, 2024
|
Tests concluants ! |
hmeneuvrier
reviewed
Jun 4, 2024
assets/vue/components/signalement-list/services/badgeFilterLabelBuilder.ts
Outdated
Show resolved
Hide resolved
numew
reviewed
Jun 4, 2024
|
hmeneuvrier
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2597
Description
Quand on commence par un tri alphabétique croissant, le tri alphabétique décroissant reste en croissant, et vice-versa, le tri n'est plus pris en compte quand on ajoute un filtre
Changer le tri "plus récent"/"plus ancien" en utilisant la date de dernier suivi plutôt que la date de dépôt (qui est redondant avec la référence)
Changements apportés
territoires[]=13parterritoire=13)Pré-requis
Les données de liste déroulante provenant de la base de données sont en cache, si besoin
Pas de date de dernier suivi sur la carte, préparer la requête SQL suivante
Si besoin de toutes les EPCIs (il y'en as quelque uns dans les fixtures)
make console app="load-epci"Tests