Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifications - Emails] Mise en place d'une adresse no-reply #2623

Merged
merged 5 commits into from
Jun 5, 2024
Merged

[Notifications - Emails] Mise en place d'une adresse no-reply #2623

merged 5 commits into from
Jun 5, 2024

Conversation

emilschn
Copy link
Collaborator

@emilschn emilschn commented Jun 3, 2024 •
edited
Loading

Ticket

#2605

Description

Mise en place d'une adresse ne-pas-repondre@histologe.beta.gouv.fr pour toutes les notifications par e-mail

Tests

  • Envoyer un e-mail via la plateforme et vérifier le header reply-to
  • Vérifier la mise en forme de l'intro du mail (le texte qui dit de ne pas répondre)
  • Envoyer un e-mail à ne-pas-repondre@histologe.beta.gouv.fr et vérifier le mail de réponse

@emilschn emilschn marked this pull request as ready for review June 3, 2024 13:45
@emilschn emilschn changed the title [WIP] [Notifications - Emails] Mise en place d'une adresse no-reply [Notifications - Emails] Mise en place d'une adresse no-reply Jun 3, 2024
hmeneuvrier
hmeneuvrier reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests OK, le mail de réponse automatique de ne-pas-repondre se met automatiquement dans ma corbeille et ressemble à

image

EDIT : il se met dans ma corbeille car j'ai un filtre pour ça :
image

src/Service/Mailer/Mail/AbstractNotificationMailer.php Outdated Show resolved Hide resolved
numew
numew approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests et relecture ok, j'approuve bien que je suis d'accord avec la remarque d'Hélène

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sfinx13
sfinx13 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@sfinx13 sfinx13 merged commit 03adf35 into develop Jun 5, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2605-reply-to branch June 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmeneuvrier hmeneuvrier hmeneuvrier left review comments

@sfinx13 sfinx13 sfinx13 approved these changes

@numew numew numew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilschn @sfinx13 @numew @hmeneuvrier